Wrap getMidenClient in withWasmClientLock in MidenProvider#143
Open
nikolaysamoil0ff wants to merge 1 commit into0xMiden:mainfrom
Open
Wrap getMidenClient in withWasmClientLock in MidenProvider#143nikolaysamoil0ff wants to merge 1 commit into0xMiden:mainfrom
nikolaysamoil0ff wants to merge 1 commit into0xMiden:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraped the eager
getMidenClient()initialization in MidenProvider withwithWasmClientLockand added the correspondingimport from ../sdk/miden-client.According to CLAUDE.md, the Miden WASM client cannot handle concurrent access, and all interactions with it must be wrapped in
withWasmClientLock. Direct calls togetMidenClient()without the lock can lead to concurrency issues, including the documented Rust error:recursive use of an object detected which would lead to unsafe aliasing in rustSince MidenProvider performs eager initialization on app startup, this could overlap with other WASM operations (e.g. workers, AutoSync, frontend hooks) and cause race conditions.